Stop attempting to delete CHAT_INPUT_COMMAND (Type 20) messages + Adjust delete delay after ratelimit to compensate ontop of current delay#527
Open
MDL-cmd wants to merge 1 commit intovictornpb:masterfrom
Conversation
…ust delete delay after ratelimit to compensate ontop of current delay
|
Thanks so much, this works like a charm. |
victornpb
added
the
PR looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undiscord attempts to delete Non-Ethereal Slash Commands (Type 20) due to blanket checking for System Messages with (msg.type >= 6 && msg.type <= 21).
This also adjusts so the ratelimit duration is added on top of the current delete delay, which will in worst case scenarios bump the delay to 1700 (but will avoid almost every ratelimit thereafter, tested with a 4000+ job archive deletion).